[nodejs] Fix issue with connection failures silently failing

[dorilla]

In node, when a connection fails, the caller is not signaled the error, it simply hangs. This solution sends a generic TApplicationException with details on the unreachable service.

a connection failure is either:

1. Service is unreachable (firewall or the service is just simply not on)
2. During a service call, the service becomes unavailable

---

To replicate:

1. Setup a service with a single endpoint (don't start the service)
2. Setup a client that calls the service endpoint
3. Call the service endpoint from the client
4. An ECONNREFUSED error occurs
   • Notice how the error is only emitted to the event loop, the calling process never gets the signal

Another way to replicate:

1. Setup a service with a single endpoint
   • code the handler to simulate a long-running piece of work (eg. long-running database query)
   • can be accomplished using a setTimeout(callback, 10000); to simulate the long-running piece of work
2. Setup a client that calls the service endpoint
3. Call the service endpoint from the client
4. After 2 seconds, before the timeout, kill the service process
5. An ECONNRESET error occurs
   • Notice how the error is only emitted to the event loop, the calling process never gets the signal

---

With the proposed fix, the callback receives the proper error, as well as the promise option.

[jeking3]

This needs to be retargeted at the master branch.

[jeking3]

This needs to be retargeted at the master branch and it needs an Apache Jira thrift ticket. See https://thrift.apache.org/docs/HowToContribute

[jeking3]

This needs to be retargeted at the master branch and it needs an Apache Jira thrift ticket. See https://thrift.apache.org/docs/HowToContribute

[jeking3]

@bananer apart from missing any testing, is this a reasonable enhancement?

[bananer]

@jeking3 This looks reasonable. Should have tests, though.

[dorilla]

Apologies, I haven't had the time to update this ticket. I fully intend to, just trying to find the time.

[jeking3]

Just a reminder, if you can move this forward based on the conversation above please do. Thanks.

[jeking3]

This is targeting the wrong branch. Closing.