THRIFT-4516: Fix "go vet" warnings for Go 1.10 #1507
Conversation
| s := NewTestStruct() | ||
| fmt.Sprintf("%v", s.read) | ||
| fmt.Sprintf("%v", s.write) | ||
| _ = s.read |
There was a problem hiding this comment.
Nice.. I had done everything else but I had no idea how to fix this in golang. Thanks!
There was a problem hiding this comment.
The problem is s.read and s.write are functions and there just isn't any way to print functions as strings, so I had to find another way to use them without trying to stringify them.
|
I'll keep an eye on this. Right now the docker images on docker.io have to be generated manually every time they are updated, otherwise the build jobs take more time than they should. |
|
Failures seem unrelated. Should I merge or do you need to do something on docker.io? |
|
Go ahead and merge. After you merge, I update my fork and kick a build on my account to refresh the images. It's an optimization that saves ~10 minutes per build job. |
3 participants
Opening this here because my free Travis account has its builds killed after 50 minutes.