Fix condition where TSimpleServer could exit AcceptLoop() without releasing lock.#1523
Closed
mdubbyap wants to merge 1 commit intoapache:masterfrom
Closed
Fix condition where TSimpleServer could exit AcceptLoop() without releasing lock.#1523mdubbyap wants to merge 1 commit intoapache:masterfrom
mdubbyap wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
Thanks for the PR. Seems like this was introduced by THRIFT-4243 (PR #1302) and unfortunately made its way into the 0.11 release. |
Member
|
Travis failures are unrelated flaky tests (my own Travis build is fine). |
Contributor
|
Thanks for checking, we need to stabilize these CI builds so less effort is spent figuring out if a change is at least somewhat ok. |
Contributor
|
THRIFT-4537 |
jgheewala
pushed a commit
to signalfx/thrift
that referenced
this pull request
Dec 11, 2018
Client: go This closes apache#1523.
hsanjuan
pushed a commit
to gxed/thrift-go
that referenced
this pull request
Jan 30, 2019
Client: go This closes apache#1523.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…easing lock