Skip to content

Update language levels, fix erlang and rust in CI#1817

Merged
jeking3 merged 3 commits intoapache:masterfrom
jeking3:ci
Jul 7, 2019
Merged

Update language levels, fix erlang and rust in CI#1817
jeking3 merged 3 commits intoapache:masterfrom
jeking3:ci

Conversation

@jeking3
Copy link
Copy Markdown
Contributor

@jeking3 jeking3 commented Jun 21, 2019

  • Include rebar3 in docker image so erlang builds in CI
  • Include the correct path in docker image so rust builds in CI
  • Updated common lisp (sbcl) to 1.5.3 in docker image
  • Updated dlang to 2.086.1 in docker image
  • Updated dart to 2.4.0 in docker image
  • Updated erlang to 22.0 in docker image
  • Updated openjdk to 11.0.3 in docker image
  • Updated node.js to 10.16 in docker image
  • Updated rust to 1.35.0 in docker image
  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? (not required for trivial changes)
  • Did you squash your changes to a single commit?
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"

@jeking3 jeking3 added the ci label Jun 21, 2019
@jeking3 jeking3 self-assigned this Jun 21, 2019
@allengeorge
Copy link
Copy Markdown
Contributor

@jeking3 Sorry for the delay. I'm trying to fix the rust tutorial build failures right now, and I'll try to fix the rust build specifically so that we use a pinned version of rustc as opposed to whatever's on stable at the time the docker container is built.

@jeking3
Copy link
Copy Markdown
Contributor Author

jeking3 commented Jul 2, 2019

Issue reproduced locally (gotta love docker containers)... looking into it.

@jeking3
Copy link
Copy Markdown
Contributor Author

jeking3 commented Jul 3, 2019

Now the erlang feature test for TLS is breaking. See what happens when a language rots because it's not being built?

@jeking3
Copy link
Copy Markdown
Contributor Author

jeking3 commented Jul 3, 2019

So erlang 22 includes erlang ssl 9.3 which disables TLS 1.0 and 1.1 by default, but TLSv1.2 doesn't seem to be working either. I'll have to back down to erlang 21 for now unless someone with some erlang knowledge can fix the TLS feature test.

@jeking3 jeking3 force-pushed the ci branch 4 times, most recently from 3f67d54 to dd10e19 Compare July 6, 2019 11:34
@jeking3
Copy link
Copy Markdown
Contributor Author

jeking3 commented Jul 7, 2019

The dlang unit test async_test is failing for ssl and hanging causing those builds to fail. This seems to be related to the newer version of dlang in use. I had upgraded from 2.083 to 2.086. I'll try to bisect it.

@jeking3
Copy link
Copy Markdown
Contributor Author

jeking3 commented Jul 7, 2019

One last thing to take care of, the Xenial Dockerfile isn't working on install of cabal.

jeking3 added 3 commits July 7, 2019 10:48
- Include rebar3 in docker image so erlang builds in CI
- Include the correct path in docker image so rust builds in CI
- Updated common lisp (sbcl) to 1.5.3 in docker image
- Updated dlang to 2.087.0 in docker image
- Updated dart to 2.0.0 in xenial docker image
- Updated dart to 2.4.0 in bionic docker image
- Updated erlang to 22.0 in docker image
- Updated openjdk to 11.0.3 in docker image
- Updated node.js to 10.16 in docker image
- Updated rust to 1.34.0 in xenial docker image
- Updated rust to 1.35.0 in bionic docker image

THRIFT-4905: Disable hanging experimental dlang async ssl test
Due to the way SSL layers on top of sockets, it was possible
to complete a connection and then have the server close it.
This would happen if the client is not checking certificates
but the server is.  The TSSLSocket unit test was enhanced to
do a read and a write as well as just connecting to ensure a
more complete test.

The TSocket read() and write() calls were leaking OSError,
socker.error, and ssl.Error exceptions.  These cases are now
wrapped into a TTransportException of the appropriate type,
and the original exception is added as an argument named inner.
The latest ssl (9.3) in erl does not support TLSv1.0 or TLSv1.1
by default and cross tests are failing.  Since csharp was
deprecated in favor of netstd, ignoring it.
@jeking3
Copy link
Copy Markdown
Contributor Author

jeking3 commented Jul 7, 2019

The issue with the Xenial build is (hopefully) a server error on the haskell server side. As such, I'm going to merge this.

@jeking3 jeking3 merged commit 08fea16 into apache:master Jul 7, 2019
@jeking3 jeking3 deleted the ci branch July 7, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants