Skip to content

THRIFT-4960 Bare Trait Warnings#1851

Closed
dbcfd wants to merge 1 commit intoapache:masterfrom
dbcfd:dyn-warnings
Closed

THRIFT-4960 Bare Trait Warnings#1851
dbcfd wants to merge 1 commit intoapache:masterfrom
dbcfd:dyn-warnings

Conversation

@dbcfd
Copy link

@dbcfd dbcfd commented Aug 21, 2019

Fixes bare trait (dyn) warnings in the library as well as generated code.

Bare traits, e.g. &mut TInputProtocol currently generate warnings which will be an error in a future rust version. Bare traits are now fixed in the rust lib and generated code to include dyn.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"? (not required for trivial changes)
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

Fixes bare trait (dyn) warnings in the library as well as generated code.
@dbcfd dbcfd mentioned this pull request Sep 6, 2019
5 tasks
@Jens-G Jens-G changed the title Bare Trait Warnings THRIFT-4960 Bare Trait Warnings Sep 11, 2019
@Jens-G Jens-G closed this in 77d96c1 Sep 11, 2019
@Jens-G
Copy link
Member

Jens-G commented Sep 11, 2019

I created a ticket for you. Next time please try to follow our contrib guide. Thank you!

@dbcfd
Copy link
Author

dbcfd commented Sep 12, 2019

Sorry @Jens-G, thought this fell under trivial change, compiler warning, since it was a rust compiler warning, but it does change the code generator. Will make an issue next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants