THRIFT-5234 Fix a number of js/ts generation issues

[pprice]

• [js] Missing class name for generated services and processors; this makes instrumentation of outbound calls (e.g. which service are we calling in to) difficult. Generating a class name for es6 enables x.constructor.name to get generated name.
• [js] Fix case where services have a method with an argument named "params", generated code generates an identifier in the "send_XXX" body named "params" which conflicts with the argument. Ensure the identifier in the body is uniquely named.
• [js] Ensure that derived services (extends XYZService) correctly call super() in their constructor.
• [ts] Ensure that derived services (extends XYZSerice) correctly specify the base class Client and Processor name
• [js] Ensure that derived service clients do not redefine private fields (output, pClass, _seqId, _reqs) and call super();
• [ts] Ensure derived service clients and processors do not redefine private fields in declaration.

[wadeDra]

I found this error : "Must call super constructor in derived class before accessing 'this' or returning from derived constructor" when I am using thrift es6.
It is bug ? How can I avoid that?

[pprice]

@wadeDra does your service derive from another service? E.g. service Foo extends Base if so; this PR would fix that particular issue. I'm still trying to figure out why the travis-ci build failed (can't reproduce locally) so I can get this landed.

FWIW the approach I took for my local build process, was to write codemods / replacements to fix up the output until I could get this landed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[emmenlau]

Dear @pprice , your PR seems valuable, could you make further progress with the travis checks? If not, do you want to try and split it into smaller logical chunks? This can help isolate what breaks travis and maybe move ahead with the other parts more quickly?

[stale]

This issue is no longer stale. Thank you for your contributions.

[wadeDra]

any progress?

[pprice]

@emmenlau Let me look at this over the next couple of days. The travis failure did seem unrelated, but I'm happy to break it up if we can get some traction on merging the changes in.

[dcelasun]

Travis failures are indeed unrelated. @pprice can you rebase from master? Also some tests would be nice.

[Jens-G]

Travis failures are indeed unrelated. @pprice can you rebase from master? Also some tests would be nice.

[pprice]

Rebased; let's give this a whirl

[pprice]

@Jens-G; CI failed again; I dug through the logs for errors; again appear to be unrelated, 3 fail for the same reason (python upgrade needed?), and 1 for either a cert error or a missing ruby gem?

6172.3, 6172.4, 6172.5

/usr/bin/python test/test.py --retry-count 5 --features .* --skip-known-failures --server cpp,c_glib,cl,d,java,csharp,py,,rb,hs,perl,php,go,nodejs,dart,erl,lua,rs,netstd,nodets
Traceback (most recent call last):
  File "test/test.py", line 45, in <module>
    assert (cur_version >= req_version), "Python 3.3 or later is required for proper operation."
AssertionError: Python 3.3 or later is required for proper operation.
Makefile:1129: recipe for target 'crossfeature' failed
make: *** [crossfeature] Error 1
RET=$?
if [ $RET -ne 0 ]; then
  cat test/log/unexpected_failures.log
fi
cat: test/log/unexpected_failures.log: No such file or directory

6172.9

/usr/bin/python test/test_sslsocket.py
........ERROR:thrift.transport.TSSLSocket:Error while accepting from ('127.0.0.1', 42976)
Traceback (most recent call last):
  File "/thrift/src/lib/py/build/lib.linux-x86_64-2.7/thrift/transport/TSSLSocket.py", line 382, in accept
    client = self._wrap_socket(plain_client)
  File "/thrift/src/lib/py/build/lib.linux-x86_64-2.7/thrift/transport/TSSLSocket.py", line 184, in _wrap_socket
    server_hostname=self._server_hostname)
  File "/usr/lib/python2.7/ssl.py", line 353, in wrap_socket
    _context=self)
  File "/usr/lib/python2.7/ssl.py", line 601, in __init__
    self.do_handshake()
  File "/usr/lib/python2.7/ssl.py", line 830, in do_handshake
    self._sslobj.do_handshake()
SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:590)
PROTOCOL_SSLv3 is not available
PROTOCOL_SSLv2 is not available

Installing binding_of_caller 0.8.0 with native extensions
An error occurred while installing byebug (11.1.1), and Bundler cannot continue.
Make sure that `gem install byebug -v '11.1.1'` succeeds before bundling.
Makefile:651: recipe for target 'all-local' failed

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[emmenlau]

Dear stale bot, please keep this issue open!

[stale]

This issue is no longer stale. Thank you for your contributions.

[Jens-G]

Theoretically we have a clean CI. Could you rebase this?

[Jens-G]

Let's give this another try. May I ask to rebase and force-push again?

[Jens-G]

Ping

[pprice]

Okay; rebased on upstread, merged and force pushed. Let's give this one more go.

[Jens-G]

That looks related:

../node_modules/.bin/html-validator --file=gen-html/index.html --verbose
Error: Validator returned unexpected statuscode: 503
at Request._callback (/thrift/src/node_modules/html-validator/index.js:32:23)
at Request.self.callback (/thrift/src/node_modules/request/request.js:185:22)
at Request.emit (events.js:198:13)
at Request. (/thrift/src/node_modules/request/request.js:1161:10)
at Request.emit (events.js:198:13)
at IncomingMessage. (/thrift/src/node_modules/request/request.js:1083:12)
at Object.onceWrapper (events.js:286:20)
at IncomingMessage.emit (events.js:203:15)
at endReadableNT (_stream_readable.js:1145:12)
at process._tickCallback (internal/process/next_tick.js:63:19)

[Jens-G]

commited 7db2d0f