THRIFT-5075: Backport changes for CVE-2019-0205 to 0.9.3.1 branch #1993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client: as3 Patch: Jens Geyer
* THRIFT-4024: make c_glib throw on unsupported type when skipping * THRIFT-4783: throw on invalid skip (py) * THRIFT-4024: make cpp throw on unsupported type when skipping * THRIFT-4024: uniform skip behavior on unsupported type
Fix Ubuntu docker build environment so it can build current code with the same set of dependencies as of when 0.9.3 was released (approximatively): - Use specific versions for some dependencies instead of the latest ones - Switch to https for maven repository - Update npm list of trusted certificates - Fix invalid change to configure.ac introduced in 0.9.4.1 - Copy gomock code from 2015 as a private module
Jens-G
added a commit
that referenced
this pull request
Feb 8, 2020
This closes #1993 THRIFT-4024, THRIFT-4783, THRIFT-4784: throw when skipping invalid type (#1742) * THRIFT-4024: make c_glib throw on unsupported type when skipping * THRIFT-4783: throw on invalid skip (py) * THRIFT-4024: make cpp throw on unsupported type when skipping * THRIFT-4024: uniform skip behavior on unsupported type * THRIFT-4784: Thrift should throw when skipping over unexpected data
Member
|
Merged, except the "fix build env" part |
|
Is it possible to get this branch released? This fix is currently unavailable for anyone still on the popular 0.9.3 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security vulnerability CVE-2019-0205 impacts several Apache projects who still uses the 0.9.3-1 Java library for Thrift. It seems unlikely those projects would be able to migrate to a more recent version of Thrift where the fix was addressed, so instead I propose to backport the small change to 0.9.3.1 branch.
[skip ci]at the end of your pull request to free up build resources.