Skip to content

THRIFT-5082: Add a Class reference for PHP enum $_TSPEC#2000

Closed
spwin wants to merge 1 commit intoapache:masterfrom
spwin:add_enum_class_to_php_tspec
Closed

THRIFT-5082: Add a Class reference for PHP enum $_TSPEC#2000
spwin wants to merge 1 commit intoapache:masterfrom
spwin:add_enum_class_to_php_tspec

Conversation

@spwin
Copy link
Copy Markdown

@spwin spwin commented Feb 4, 2020

Issue described in the ticket: https://issues.apache.org/jira/browse/THRIFT-5082

This adds the class reference to PHP $_TSPEC

BEFORE

5 => array(
  'var' => 'group_type',
  'isRequired' => true,
  'type' => TType::I32,
  ),

AFTER

5 => array(
  'var' => 'group_type',
  'isRequired' => true,
  'type' => TType::I32,
  'class' => '\thrift\groups\GroupType',
  ),

@mmuszynskifln
Copy link
Copy Markdown

Nice!

@spwin
Copy link
Copy Markdown
Author

spwin commented Apr 6, 2020

bump

@dcelasun
Copy link
Copy Markdown
Member

Thanks for the PR @spwin! Can you please add a test case so this won't regress in the future?

@Jens-G Jens-G closed this in 3f78c70 Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants