THRIFT-5211: Haskell: Handle incomplete reads correctly.

[phile314]

The read functions for handles promise to return up to the requested number of bytes. This means in case we read less bytes, we should try again to read some more bytes. This issue caused invalid frame sizes which caused arbitrary decoding failures.

I believe that the bug has been introduced in 3c42007

• Did you create an Apache Jira ticket? (not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

[Jens-G]

@phile314 we are looking for people who want to get more involved with Thrift as languange maintainers. Interested?

[Jens-G]

+1 LGTM, not tested

[phile314]

@Jens-G Thanks for reviewing my PR. Regarding becoming a thrift haskell maintainer, as far as I can tell, the Haskell bindings and thrift in general are quite mature and stable. So if it is only the occasional pull request to review, I am happy to do that. If it involves implementing big new features or going on long bug hunts for other peoples issues, then I am less inclined to do so.

[zeshuai007]

Hi @Jens-G , I am a Thrift enthusiast, and I'm familiar with several programming languages.
I use Thrift a lot and it's awesome, cause we can flexibly choose the language we need.
During my use of Thrift, I found that it still has many features that could be optimized, such as
more detailed documentation, modern c++ compatibility, test case coverage, etc.
I am very interested in Thrift and hoping to be one of the committers if possible.