THRIFT-5183: Don't try to read next frame in THeaderTransport.Read#2110
Merged
dcelasun merged 1 commit intoapache:masterfrom Apr 24, 2020
Merged
THRIFT-5183: Don't try to read next frame in THeaderTransport.Read#2110dcelasun merged 1 commit intoapache:masterfrom
dcelasun merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@dcelasun :) |
fishy
force-pushed
the
go-theader-fix-bug
branch
from
dc043e3 to
3398c3d
Compare
Member
|
Nice catch @fishy! Could you maybe add a test so this won't regress in a potential refactor down the line? |
fishy
force-pushed
the
go-theader-fix-bug
branch
from
3398c3d to
c1a5788
Compare
Member
Author
|
@dcelasun Test added. |
fishy
force-pushed
the
go-theader-fix-bug
branch
from
c1a5788 to
fbac38b
Compare
Client: go Trying to read the next frame will likely cause the Read call blocking indefinitely and eventually lead to timeout. See the JIRA ticket for more context.
fishy
force-pushed
the
go-theader-fix-bug
branch
from
fbac38b to
2f37702
Compare
Member
|
Thanks! CI failures are unrelated so I'm merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: go
Trying to read the next frame will likely cause the Read call blocking
indefinitely and eventually lead to timeout. See the JIRA ticket for
more context.
[skip ci]at the end of your pull request to free up build resources.