Skip to content

THRIFT-5184: Fix Connection header check for Firefox when establishing a WebSocket connection#2112

Closed
penenin wants to merge 1 commit intoapache:masterfrom
penenin:THRIFT-5184
Closed

THRIFT-5184: Fix Connection header check for Firefox when establishing a WebSocket connection#2112
penenin wants to merge 1 commit intoapache:masterfrom
penenin:THRIFT-5184

Conversation

@penenin
Copy link
Copy Markdown
Contributor

@penenin penenin commented Apr 23, 2020

When establishing a WebSocket connection, Firefox sends Connection: keep-alive, Upgrade instead of just Connection: Upgrade. Check to see if Upgrade is in the header instead of checking to see if it is the entire header value.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, add [skip ci] at the end of your pull request to free up build resources.

@penenin penenin closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant