THRIFT-5203: Remove Unused toString Method in TSerializer #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Jens-G Can you take a look at this one too? Thanks!! |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This issue is no longer stale. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Member
|
. |
|
This issue is no longer stale. Thank you for your contributions. |
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Mar 29, 2021
Motivation: Thrift has been released 0.14.0 with breaking changes. - apache/thrift#2208 - apache/thrift#2138 We need a workaround to share Armeria Thrift implementions from 0.9 to 0.14.0 Modifications: - Add `armeria-thrift0.14` module - Copy sources from `armeria-thrift0.13` and override `TByteBufTransport` for implementing newly added API - Catch checked exceptions which are newly added and throws unsafely for compatibility - The checked exceptions will not be raised actually - Use `armeria-thrift0.14` as the default dependencies for Armeria modules and testing Result: - You can now use Thrift 0.14.x with Armeria Thrift server and client - Fixes line#3370
1 task
trustin
pushed a commit
to line/armeria
that referenced
this pull request
Apr 5, 2021
Motivation: Thrift has been released 0.14.0 with breaking changes. - apache/thrift#2208 - apache/thrift#2138 We need a workaround to share Armeria Thrift implementions from 0.9 to 0.14.0 Modifications: - Add `armeria-thrift0.14` module - Copy sources from `armeria-thrift0.13` and override `TByteBufTransport` for implementing newly added API - Catch checked exceptions which are newly added and throws unsafely for compatibility - The checked exceptions will not be raised actually - Use `armeria-thrift0.14` as the default dependencies for Armeria modules and testing Result: - You can now use [libthrift 0.14.x](https://search.maven.org/artifact/org.apache.thrift/libthrift/0.14.1/jar) with Armeria Thrift server and client - Fixes #3370
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip ci]anywhere in the commit message to free up build resources.