Skip to content

Conversation

@penenin
Copy link
Contributor

@penenin penenin commented May 22, 2020

Client: cpp

Remove portable_endian.h

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@penenin
Copy link
Contributor Author

penenin commented May 22, 2020

Is there a way to force the CI to rerun? One test failure is in netstd, another is in Java and the third looks like it might be transient since it was an iostream error. I would like to rerun that last test.

@janosvitok
Copy link
Contributor

You may try 1) rebase branch on current master 2) push --force

@dcelasun
Copy link
Member

I've restarted the CI build.

@emmenlau
Copy link
Member

I'm also testing the branch over the weekend. Thanks for the quick response!

@penenin
Copy link
Contributor Author

penenin commented May 22, 2020

That time the failing test was because of a 504 on a git clone. (I believe it passed the first time.) I tried git push --force but it didn't seem to kick off the CI again. I am already up-to-date on master. I'll wait until the next commit and then rebase the branch again.

@dcelasun
Copy link
Member

All tests are green!

@ulidtko
Copy link
Contributor

ulidtko commented May 23, 2020

To kick CI, just do empty git commit --amend followed by git push -f. This will modify dates of your HEAD commit, and therefore change the commit sha, and so will be seen as new content by CI bots.

@Jens-G Jens-G closed this in e6d7d13 May 26, 2020
sveneld pushed a commit to sveneld/thrift that referenced this pull request May 29, 2020
Client: cpp
Patch: James Lacey

This closes apache#2152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants