Removed reference to nonexisting tests from cabal file #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Oops, just noticed that the build failed. I really don't see why it fails in the log, or what it has to do with this change more precisely. An idea? |
Member
|
Failed in JS part - probably not your fault ;) |
Author
|
Okay, I feel better already ;-). Do I do something with this merge request then or do I leave it like this? |
Member
|
leave it - I just added comment for bot to automagically link it with Jira issue :) |
Author
|
Ok. |
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Patch: Kasper Janssens Github Pull Request: This closes apache#222
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
Update Configuration.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for reference in cabal file for the Haskell example. The Cabal file referred a test that didn't exist anymore. From the discussion in the ticket it seemed best to just remove it, as cabal will complain about not finding a test when you're trying to build.