Fixed double newline at end of generated python service files#2236
Merged
fishy merged 1 commit intoapache:masterfrom Sep 14, 2020
Merged
Fixed double newline at end of generated python service files#2236fishy merged 1 commit intoapache:masterfrom
fishy merged 1 commit intoapache:masterfrom
Conversation
Fixed double endline at end of service files
fishy
approved these changes
Sep 14, 2020
Member
fishy
left a comment
fishy
left a comment
There was a problem hiding this comment.
LGTM. Also verified that all CI failures are existing ones. Thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain the changes in the pull request below:
Generated python files have a blank line at the end of files, except for service files where there are two blank lines, this change makes these service files consistent.
This change is trivial and thus does not require a ticket.