Skip to content

Conversation

@emmenlau
Copy link
Member

There is a symbolic link in the repository to point to a shell script. I'm under the impression that a relative path in the corresponding Makefile.am serves the same purpose. Lets see if the CI agrees.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Copy link
Member

@zeshuai007 zeshuai007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@emmenlau
Copy link
Member Author

Rebased on latest master.

If the build goes through now, this PR should have rather low potential for problems. And it brings a big benefit because symlinks in git make so often problems on Windows.

@emmenlau
Copy link
Member Author

The Travis errors seem to be all unrelated. Please consider for merge.

@zeshuai007 zeshuai007 merged commit b72b674 into apache:master Nov 28, 2020
@emmenlau emmenlau deleted the bda_remove_symlink branch December 2, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants