-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Diverse cmake improvements in dependency handling #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diverse cmake improvements in dependency handling #2283
Conversation
ulidtko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (though ThriftConfig.cmake.in doesn't look that good to me...)
ulidtko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think you'll need to bring back the FindLibevent.cmake file, @emmenlau. It's not included in CMake distribution, this will break.
c1b6afe to
7876758
Compare
|
@ulidtko Yes you are right, I've come to the same thinking. I'm using libevent with cmake, but other people may use it from their distro. Re-added |
ulidtko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes sure, LGTM now.
49ad4e2 to
97e8f8d
Compare
|
I've re-added all the support for libevent found via the provided cmake find script, but also added detection for the newer cmake configuration via targets. Basically, cmake should now support libevent in all cases. Lets see if the CI agrees. |
97e8f8d to
0e84ca5
Compare
|
The Travis CI build errors are from autotools builds and should be unrelated. Please consider for merge. |
0e84ca5 to
5556275
Compare
zeshuai007
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
5556275 to
c981d93
Compare
c981d93 to
7553fc5
Compare
|
Rebased on latest master. I plan to merge this PR ASAP (if CI remains green against latest master). |
This PR adds a few improvements in cmake dependency handling. Previously, the cmake build did not pass dependencies so well downstream to dependent projects. This PR ensures that all possible dependencies (including thriftz and thriftnb) are passed correctly.
This PR also removes the find-script for libevent. Generally libevent can nowadays often be found with the cmake config. However this may be a breaking change(?)
[skip ci]anywhere in the commit message to free up build resources.