Skip to content

THRIFT-5329: Shorten names of inner classes #2299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rtvd wants to merge 1 commit into from
Closed

THRIFT-5329: Shorten names of inner classes #2299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions compiler/cpp/src/thrift/generate/t_java_generator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4878,11 +4878,11 @@ void t_java_generator::generate_field_descs(ostream& out, t_struct* tstruct) {
}
}

void t_java_generator::generate_scheme_map(ostream& out, t_struct* tstruct) {
void t_java_generator::generate_scheme_map(ostream& out, t_struct*) {
indent(out) << "private static final org.apache.thrift.scheme.SchemeFactory STANDARD_SCHEME_FACTORY = new "
<< tstruct->get_name() << "StandardSchemeFactory();" << endl;
<< "StandardSchemeFactory();" << endl;
indent(out) << "private static final org.apache.thrift.scheme.SchemeFactory TUPLE_SCHEME_FACTORY = new "
<< tstruct->get_name() << "TupleSchemeFactory();" << endl;
<< "TupleSchemeFactory();" << endl;
}

void t_java_generator::generate_field_name_constants(ostream& out, t_struct* tstruct) {
Expand Down Expand Up @@ -5268,18 +5268,18 @@ void t_java_generator::generate_standard_writer(ostream& out, t_struct* tstruct,
void t_java_generator::generate_java_struct_standard_scheme(ostream& out,
t_struct* tstruct,
bool is_result) {
indent(out) << "private static class " << tstruct->get_name()
indent(out) << "private static class "
<< "StandardSchemeFactory implements org.apache.thrift.scheme.SchemeFactory {" << endl;
indent_up();
indent(out) << "public " << tstruct->get_name() << "StandardScheme getScheme() {" << endl;
indent(out) << "public StandardScheme getScheme() {" << endl;
indent_up();
indent(out) << "return new " << tstruct->get_name() << "StandardScheme();" << endl;
indent(out) << "return new StandardScheme();" << endl;
indent_down();
indent(out) << "}" << endl;
indent_down();
indent(out) << "}" << endl << endl;

out << indent() << "private static class " << tstruct->get_name()
out << indent() << "private static class "
<< "StandardScheme extends org.apache.thrift.scheme.StandardScheme<" << tstruct->get_name() << "> {" << endl << endl;
indent_up();
generate_standard_reader(out, tstruct);
Expand Down Expand Up @@ -5386,17 +5386,17 @@ void t_java_generator::generate_java_struct_tuple_writer(ostream& out, t_struct*
}

void t_java_generator::generate_java_struct_tuple_scheme(ostream& out, t_struct* tstruct) {
indent(out) << "private static class " << tstruct->get_name()
indent(out) << "private static class "
<< "TupleSchemeFactory implements org.apache.thrift.scheme.SchemeFactory {" << endl;
indent_up();
indent(out) << "public " << tstruct->get_name() << "TupleScheme getScheme() {" << endl;
indent(out) << "public TupleScheme getScheme() {" << endl;
indent_up();
indent(out) << "return new " << tstruct->get_name() << "TupleScheme();" << endl;
indent(out) << "return new TupleScheme();" << endl;
indent_down();
indent(out) << "}" << endl;
indent_down();
indent(out) << "}" << endl << endl;
out << indent() << "private static class " << tstruct->get_name()
out << indent() << "private static class "
<< "TupleScheme extends org.apache.thrift.scheme.TupleScheme<" << tstruct->get_name() << "> {" << endl << endl;
indent_up();
generate_java_struct_tuple_writer(out, tstruct);
Expand Down