Skip to content

Conversation

@penenin
Copy link
Contributor

@penenin penenin commented Feb 3, 2021

  1. Use the first entry in the address list like TSocketTransport. No need to try to create another IPAddress object.
  2. Save the host name if provided and use that when calling AuthenticateAsClientAsync().
  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G self-requested a review February 4, 2021 08:05
@Jens-G Jens-G closed this in 55016bf Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant