Skip to content

TCompactProtocol and TJSONProtocol need boundary checking #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
psi29a wants to merge 2 commits into from
Closed

TCompactProtocol and TJSONProtocol need boundary checking #234

psi29a wants to merge 2 commits into from

Conversation

@psi29a
Copy link

@psi29a psi29a commented Oct 2, 2014

added use cases to check boundaries on signed ints, TCompact and TJSON failed and are now properly raising errors on bad imput like upack does in the binary protocols

@psi29a
added use cases to check boundaries on signed ints, TCompact and TJSO…
b2a3df3 
…N failed and are now properly raising errors on bad imput like upack does in the binary protocols
@hcorg
Copy link
Member

hcorg commented Oct 2, 2014

Please create Jira issue and paste link to it in comment here.

http://thrift.apache.org/docs/HowToContribute

@psi29a
Copy link
Author

psi29a commented Oct 2, 2014

Would love to, but your link seems to be broken. If you click on the Jira link it goes here:
https://thrift.apache.org/docs/%7B%7B%20conf.jira_url%20%7D%7D

Not Found
The requested URL /docs/{{ conf.jira_url }} was not found on this server.
Apache/2.4.10 (Unix) mod_wsgi/3.5 Python/2.7.5 OpenSSL/1.0.1i Server at thrift.apache.org Port 80

I assume you mean this: https://issues.apache.org/jira/browse/THRIFT <-- found via google

@hcorg
Copy link
Member

hcorg commented Oct 2, 2014

wow... link to JIra: https://issues.apache.org/jira/browse/THRIFT

I'll try to check what is going on with broken thrift.apache.org

@asfbot
Copy link

asfbot commented Oct 2, 2014

Thrift-precommit #8 FAILURE
Looks like there's a problem with this pull request

@psi29a
Copy link
Author

psi29a commented Oct 2, 2014

Issue created here:
https://issues.apache.org/jira/browse/THRIFT-2757

@asfbot
Copy link

asfbot commented Oct 2, 2014

Thrift-precommit #9 FAILURE
Looks like there's a problem with this pull request

hcorg added a commit to hcorg/thrift that referenced this pull request Oct 8, 2014
@hcorg
THRIFT-2757: py - Added integer limits checks in compact and JSON pro…
b219e0e 
…tocols

Client: Python
Patch: Bret Curtis

This closes: apache#234
asfgit pushed a commit that referenced this pull request Oct 8, 2014
@hcorg
THRIFT-2757: py - Added integer limits checks in compact and JSON pro…
93fea15 
…tocols

Client: Python
Patch: Bret Curtis

This closes: #234
@hcorg
Copy link
Member

hcorg commented Oct 8, 2014

please close this request - I don't know why bot didn't close it.. (maybe extra colon...)

@jfarrell jfarrell closed this Oct 8, 2014
allengeorge pushed a commit to allengeorge/thrift that referenced this pull request Jan 1, 2017
@hcorg
THRIFT-2757: py - Added integer limits checks in compact and JSON pro…
8dcefb5 
…tocols

Client: Python
Patch: Bret Curtis

This closes: apache#234
Jens-G pushed a commit to Jens-G/thrift that referenced this pull request Apr 14, 2019
@mgravell
Merge pull request apache#234 from JonCole/master
83a046e 
Add ClientName to output for timeout messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@psi29a @hcorg @asfbot @jfarrell