Skip to content

THRIFT-5407: Minor changes in .NET to support netcoreapp3.1#2384

Closed
emmenlau wants to merge 1 commit intoapache:masterfrom
BioDataAnalysis:bda_fix_netcore31
Closed

THRIFT-5407: Minor changes in .NET to support netcoreapp3.1#2384
emmenlau wants to merge 1 commit intoapache:masterfrom
BioDataAnalysis:bda_fix_netcore31

Conversation

@emmenlau
Copy link
Copy Markdown
Member

@emmenlau emmenlau commented May 5, 2021

This PR re-adds support for .NET CORE 3.1. It still requires latest .NET CORE to build. Users need to manually switch the build from net5.0 to netcoreapp3.1. This can be done in DotNet or directly in the csproj files.

  • Apache Jira ticket https://issues.apache.org/jira/browse/THRIFT-5407
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@emmenlau emmenlau requested a review from Jens-G May 5, 2021 08:54
@Jens-G Jens-G closed this in aeb8964 May 5, 2021
@emmenlau emmenlau deleted the bda_fix_netcore31 branch May 6, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant