Skip to content

Conversation

@elludraon
Copy link
Contributor

@elludraon elludraon commented May 18, 2021

Add missing default argument values for service client functions in generated Lua code.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G
Copy link
Member

Jens-G commented May 19, 2021

That's the case for a lot of them, not just Lua. Thanks!

@Jens-G Jens-G self-requested a review May 19, 2021 07:00
@huzhao37
Copy link

huzhao37 commented May 20, 2021

When I use Compact protocol to codec complex structures, I call initialize, assign a value to one of the simple string types, then encode, get buffer, and then decode, I find that the value of the field of string type is missing, if I initialize other complex fields in the complex structure, I won't have this problem, how to solve this?
image
image

@Jens-G
Copy link
Member

Jens-G commented May 20, 2021

... how to solve this?

We have a mailing list. Actually we have two mailing lists. I'd recommend to ask there, it seems too offtopic.

@Jens-G Jens-G closed this in c54cfcb May 20, 2021
@Jens-G Jens-G removed their request for review May 20, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants