Skip to content

Conversation

@thomasbruggink
Copy link
Contributor

@thomasbruggink thomasbruggink commented May 28, 2021

Client java

Throw an exception when reading TSimpleJson and update the comment
explain why.

I'm wondering if just throwing is acceptable since this will break backwards compatibility with clients that actually try to read. Let me know if just updating the comment would be a better solution.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client java

Throw an exception when reading TSimpleJson and update the comment
explain why.
@Jens-G
Copy link
Member

Jens-G commented Jun 23, 2021

+1 Looks reasonable to me, I'm for it.

@Jens-G Jens-G closed this in 3c3a389 Jun 30, 2021
@thomasbruggink thomasbruggink deleted the simple-json branch July 1, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants