THRIFT-5447: Update supported Go versions #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
commented
Aug 4, 2021
|
|
||
| export GOPATH=$(mktemp -d -t gopath-XXXXXXXXXX) | ||
|
|
||
| # TODO: Once we dropped support to go 1.15, add "@v1.5.0" suffix to go install |
Member
Author
There was a problem hiding this comment.
NOTE: I removed this TODO because I realized that without "@v1.5.0", go install will actually pick the version according to go.mod, which is better because we won't need to keep the two versions in sync.
fishy
force-pushed
the
update-go-versions
branch
from
6fff3c9 to
37d342e
Compare
dcelasun
approved these changes
Aug 5, 2021
fishy
force-pushed
the
update-go-versions
branch
from
37d342e to
8f8d3b0
Compare
fishy
force-pushed
the
update-go-versions
branch
3 times, most recently
from
3cf9d80 to
ddf175a
Compare
Client: go Update go versions used in travis to 1.16.7 and 1.17, update LANGUAGES.md, and update go's README to clarify on support policy. This change will be cherry-picked into 0.15.0 branch after merged.
fishy
force-pushed
the
update-go-versions
branch
from
ddf175a to
907c695
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client: go
Update go versions used in travis to 1.16.7 and 1.17, update
LANGUAGES.md, and update go's README to clarify on support policy.
This change will be cherry-picked into 0.15.0 branch after merged.