Use the cmake-generated thrift config also on MSVC #2447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmenlau
force-pushed
the
bda_use_cmake_config_on_msvc
branch
from
e9855f2 to
57554d2
Compare
Member
Author
|
The failed test on AppVeyor MSVC 2015 seems unrelated. |
fishy
approved these changes
Aug 29, 2021
Member
fishy
left a comment
fishy
left a comment
There was a problem hiding this comment.
I'm not familiar with MSVC nor cmake but this certainly passes a lot more travis tasks than before so looks good to me :)
emmenlau
force-pushed
the
bda_use_cmake_config_on_msvc
branch
from
57554d2 to
5a64c71
Compare
Member
Author
|
Rebased on latest master to fix .NET installation issues on Travis |
Member
Author
|
Remaining errors on Travis are all unrelated :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the cmake-generated header
config.his not used on MSVC. However it can be helpful to have the option to use this header, for example to detect the presence of newer Windows SDK features (like used in #2327).I've tested this addition for over a year successfully on various combinations of Windows and did not find any issues or problems. I've also tried to make sure that previous Windows defines remain available unless overridden by cmake (which should be a good thing).
[skip ci]anywhere in the commit message to free up build resources.