THRIFT-5499: Use blocking Read/Write calls to make sure the Receive/S…#2517
Merged
Jens-G merged 1 commit intoapache:masterfrom Feb 10, 2022
Merged
THRIFT-5499: Use blocking Read/Write calls to make sure the Receive/S…#2517Jens-G merged 1 commit intoapache:masterfrom
Jens-G merged 1 commit intoapache:masterfrom
Conversation
…endTimeout is checked. Client: netstd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…endTimeout is checked.
Client: netstd
The Read/Write operations on the TCP-stream are now blocking calls wrapped in a Task.
This ensures the Send/ReceiveTimeout properties of the TcpClient are used.
It is important that the (TSocket)Transport is closed/disposed when this exception is thrown.
Otherwise the next Read operation will read the message that is sent after the timeout in the stream.
Imo this is not a breaking change because this is the desired behavior.
[skip ci]anywhere in the commit message to free up build resources.