Skip to content

THRIFT-5499: Use blocking Read/Write calls to make sure the Receive/S…#2517

Merged
Jens-G merged 1 commit intoapache:masterfrom
TeinRnD:master
Feb 10, 2022
Merged

THRIFT-5499: Use blocking Read/Write calls to make sure the Receive/S…#2517
Jens-G merged 1 commit intoapache:masterfrom
TeinRnD:master

Conversation

@TeinRnD
Copy link
Contributor

@TeinRnD TeinRnD commented Feb 8, 2022

…endTimeout is checked.

Client: netstd

The Read/Write operations on the TCP-stream are now blocking calls wrapped in a Task.
This ensures the Send/ReceiveTimeout properties of the TcpClient are used.

It is important that the (TSocket)Transport is closed/disposed when this exception is thrown.
Otherwise the next Read operation will read the message that is sent after the timeout in the stream.

Imo this is not a breaking change because this is the desired behavior.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@Jens-G Jens-G self-requested a review February 8, 2022 16:11
@Jens-G Jens-G merged commit 52d263e into apache:master Feb 10, 2022
@Jens-G Jens-G removed their request for review February 10, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants