THRIFT-5551: java generator to add @Override where possible

[jimexist]

java generator to add @OverRide where possible

• Did you create an Apache Jira ticket? (not required for trivial changes)
• If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
• Did you squash your changes to a single commit? (not required, but preferred)
• Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
• If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

[ctubbsii]

These changes are harder to review than necessary, because they contain a lot of style changes. I would recommend minimizing the changes in this PR by retaining the existing style, so it's easier to review. For style standardization/improvements, I'd suggest creating a separate PR that does only that and no substantive changes.

[jimexist]

These changes are harder to review than necessary, because they contain a lot of style changes. I would recommend minimizing the changes in this PR by retaining the existing style, so it's easier to review. For style standardization/improvements, I'd suggest creating a separate PR that does only that and no substantive changes.

Thanks for the suggestion - I wonder it too. The formatting changes were made by my editor, and I don't have a good way to separate it from the actual changes now.

If it's okay do you think I can create a separate, clean, style only change and merge that first. And then this change can be much cleaner? @ctubbsii

[ctubbsii]

If it's okay do you think I can create a separate, clean, style only change and merge that first. And then this change can be much cleaner?

Yeah, I think that would be a good option. If a standard style can be enforced by people with any editor, something like what the formatter-maven-plugin provides for Java code, that would be even better, I would think.

[jimexist]

yes @ctubbsii the tool is clang-format and it's also centrally configured here - which is also what my editor formatting is relying on.

• I'm creating THRIFT-5552: apply clang-format to java generator #2560 as style only format to precede this change

[ctubbsii]

I just learned about clang-format. It seems nice... but a quick check shows it's defaults would change a lot of thrift code, and not always for the better. I'm not sure if the Thrift community would endorse its use, but there is a .clang-format file in the root directory. It seems it hasn't been run in awhile. It might be easier to just look over this PR and try to undo the formatting changes. Or, just rely on reviewers to figure it out.

[ctubbsii]

@jimexist I think you need to rebase and force-push to get this up-to-date.

[ctubbsii]

Overall, this looks pretty good to me. I haven't verified that all the new uses are actually overrides, but it will be pretty obvious if they aren't... it will generate code that won't compile if they aren't.

[jimexist]

@Override is _since_ 5.0

[Jens-G]

That's a test, right? Seen and fixed.