THRIFT-2852 Better open/close behavior for StreamTransport. #285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
stigsb
pushed a commit
to stigsb/thrift
that referenced
this pull request
Nov 28, 2014
Client: Go Patch: Chi Vinh Le <cvl@chinet.info> This closes apache#285
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: Go Patch: Chi Vinh Le <cvl@chinet.info> This closes apache#285
hsanjuan
pushed a commit
to gxed/thrift-go
that referenced
this pull request
Jan 30, 2019
Client: Go Patch: Chi Vinh Le <cvl@chinet.info> This closes apache#285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use StreamTransport a lot to test functionality locally that otherwise uses a Socket transport. Current implementation of IsOpen returns always true, even though after a close, the whole transport is not usable.
This PR implements IsOpen, Open and Close that reflects the internal state and behaves more similar to other transports like TSocket.
Includes a test case.