Closed
Conversation
Line buffering results in slow performance on FUSE- and network-based file systems, e.g., eCryptfs. std::ostream << std::endl emits a newline and flushes buffers to the kernel[1], yielding excessive system calls. Instead, emit "\n" which does the equivalent without the flush[2]. The attached patch accomplishes this while minimizing code churn by removing "using namespace std" and introducing a static variable endl. [1] http://www.cplusplus.com/reference/ios/endl/ [2] http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line buffering results in slow performance on FUSE- and network-based
file systems, e.g., eCryptfs. std::ostream << std::endl emits a
newline and flushes buffers to the kernel[1], yielding excessive
system calls. Instead, emit "\n" which does the equivalent without
the flush[2]. The attached patch accomplishes this while minimizing
code churn by removing "using namespace std" and introducing a static
variable endl.
[1] http://www.cplusplus.com/reference/ios/endl/
[2] http://stackoverflow.com/questions/5492380/what-is-the-c-iostream-endl-fiasco