T monkeypatch thrift module#33
Closed
axos88 wants to merge 25 commits into
Closed
Conversation
…ffer implementation
…e faster as it does not allocate a new ruby string each time
…ead by adding a get_method_table function to the layered protocol that can be used to retrieve a table of C function pointers to the API of the protocol layer
Author
|
Sorry, this was a mistake, a preliminary code review for our whitepages fork. Please ignore. |
keynslug
pushed a commit
to keynslug/thrift
that referenced
this pull request
Feb 27, 2017
…um_ref_in_typedef BJ-76: Add struct and enum ref in typedef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fastcall struct that may be used to call by supplying a C function pointer or by rb_funcall if the C fptr is unavailable.
use by initailizing the fastcall by either fastcall_init_ruby (use rb_funcall), or fastcall_init_c (use a C fptr), and the call using fastcall_call(fastcall_struct, object, parameters)
Drawback is that one parameter must be supplied, even if the needed parameters is 0, supply Qnil in this case.
Added a new function to the protocol layer API, named get_protocol_method_table, which - if implemented - will return a C protocol_method_table structure containing the fastcall objectc to call its API. This is used to prevent having to switch ro ruby and back to C when two communicating layers are both implemented in C.