THRIFT-5926: Fix TSaslClientTransport.open() for DIGEST-MD5#3342
Open
ShreyeshArangath wants to merge 1 commit intoapache:masterfrom
Open
THRIFT-5926: Fix TSaslClientTransport.open() for DIGEST-MD5#3342ShreyeshArangath wants to merge 1 commit intoapache:masterfrom
ShreyeshArangath wants to merge 1 commit intoapache:masterfrom
Conversation
- Handle None initial response from sasl.process() with explicit is-not-None check instead of or-coercion - Process server's final challenge on COMPLETE status (rspauth verification for DIGEST-MD5) - Add None guard in send_sasl_msg to match Java TSaslTransport - Fix recv_sasl_msg to return b"" instead of "" for zero-length payloads - Add unit tests for SASL negotiation including error paths
07f7ef5 to
a119915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple critical failures in TSaslClientTransport.open() when using challenge-response SASL mechanisms (like DIGEST-MD5). These issues previously led to TypeErrors, failed mutual authentication, and protocol desynchronization.
Here are some of the problems:
[skip ci]anywhere in the commit message to free up build resources.