Regression test for THRIFT-4002: Immutable exception deserialization#3349
Merged
Jens-G merged 1 commit intoapache:masterfrom Mar 20, 2026
Merged
Conversation
Client: py Patch: Jens Geyer Generated-by: Opencode big-pickle This test verifies that immutable structs (including exceptions, which are immutable by default since Thrift 0.14.0) can be properly deserialized without triggering the __setattr__ TypeError. The bug manifests when: 1. A struct class is marked immutable (has __setattr__ that raises TypeError) 2. Thrift's deserialization tries to set attributes via setattr instead of using the kwargs constructor Test coverage: - Immutable exception creation and hashability - Immutable exception blocks modification/deletion - Round-trip serialization/deserialization with TBinaryProtocol - Round-trip serialization/deserialization with TCompactProtocol - Accelerated protocol tests (C extension) when available Related: THRIFT-4002, THRIFT-5715
Jens-G
force-pushed
the
THRIFT-4002-immutable-exception-deserialization
branch
from
db99552 to
2dc4dbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client: py
Patch: Jens Geyer
Generated-by: Opencode big-pickle
This test verifies that immutable structs (including exceptions, which are immutable by default since Thrift 0.14.0) can be properly deserialized without triggering the setattr TypeError.
The bug manifests when:
Test coverage:
Related: THRIFT-4002, THRIFT-5715