Skip to content

THRIFT-5940: Make generated Ruby code RuboCop compliant#3388

Open
kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk:rb-gen-rubocop
Open

THRIFT-5940: Make generated Ruby code RuboCop compliant#3388
kpumuk wants to merge 1 commit intoapache:masterfrom
kpumuk:rb-gen-rubocop

Conversation

@kpumuk
Copy link
Copy Markdown
Contributor

@kpumuk kpumuk commented Apr 9, 2026

This change addresses Rubocop offenses in the generated code, mostly spacing:

  • extra blank lines around top-level generated blocks
  • message=nil instead of message = nil
  • trailing whitespace in generated service inheritance lines
  • enum constant rendering with incorrect indentation
  • blank RDoc lines emitted as # (trailing whitespace) instead of #

Additionally, we generate all Thrift files for Ruby so that SCA job actually ensures they are compliant.

  • Did you create an Apache Jira ticket? THRIFT-5940
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client: rb

Co-Authored-By: OpenAI Codex (GPT-5.4) <codex@openai.com>
@mergeable mergeable bot added compiler github_actions Pull requests that update GitHub Actions code labels Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

compiler github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant