Skip to content

Remove unused Ruby client reply helpers#3395

Merged
kpumuk merged 1 commit into
apache:masterfrom
kpumuk:seqid-rb-cleanup
Apr 18, 2026
Merged

Remove unused Ruby client reply helpers#3395
kpumuk merged 1 commit into
apache:masterfrom
kpumuk:seqid-rb-cleanup

Conversation

@kpumuk
Copy link
Copy Markdown
Member

@kpumuk kpumuk commented Apr 14, 2026

This is a follow-up to #3345. I left the old helpers around, so that code generated with the compiler pre- and post- seqid change would work (although pre- would not generate correct sequence IDs nor validate them).

With this cleanup we force people to re-generate, as per Ruby documentation on version upgrade. This will also go into the next release (0.24.0), so I feel like it should not affect anybody.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@mergeable mergeable Bot added the ruby label Apr 14, 2026
@kpumuk kpumuk force-pushed the seqid-rb-cleanup branch from 90b6621 to 7d4c6ff Compare April 15, 2026 13:56
@kpumuk kpumuk force-pushed the seqid-rb-cleanup branch from 7d4c6ff to 5344453 Compare April 17, 2026 02:24
@kpumuk
Copy link
Copy Markdown
Member Author

kpumuk commented Apr 17, 2026

@Jens-G this is somewhat a lower risk PR, do you mind if I merge it to practice? I was looking at https://thrift.apache.org/docs/committers/HowToCommit.html and it seem kind of outdated. Thinking about something like

gh api -H "Accept: application/vnd.github.v3.patch" repos/:owner/:repo/pulls/3395 | git am --ignore-space-change
 
git log --format=fuller -n1
────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
commit 77151745bac95752cf2d745215c7639ffcd114a5 (HEAD -> master)
Author:     Dmytro Shteflyuk <kpumuk@apache.org>
AuthorDate: Thu Apr 16 22:24:48 2026 -0400
Commit:     Dmytro Shteflyuk <kpumuk@apache.org>
CommitDate: Thu Apr 16 23:40:35 2026 -0400

    Remove unused Ruby client reply helpers

Output seems to match (somewhat) what you have been doing. Would probably add Client as well, not quite sure how Patch is relevant given Author is preserved as is.

Copy link
Copy Markdown
Member

@Jens-G Jens-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure commit away 🚀.

I do it usually either directly via Github UI, or squash/rebase locally, whatever fits best. In the latter case I usually rewrite the commit message to adhere to the format you linked to. So far I never used the GH tool manually, but that should do as well of course.

@kpumuk kpumuk merged commit 4d01191 into apache:master Apr 18, 2026
144 of 145 checks passed
@kpumuk kpumuk deleted the seqid-rb-cleanup branch April 18, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants