Skip to content

Improve ruby gemspec#3426

Closed
Jens-G wants to merge 1 commit into
apache:masterfrom
Jens-G:rb-gemspec
Closed

Improve ruby gemspec#3426
Jens-G wants to merge 1 commit into
apache:masterfrom
Jens-G:rb-gemspec

Conversation

@Jens-G
Copy link
Copy Markdown
Member

@Jens-G Jens-G commented Apr 28, 2026

WARNING:  open-ended dependency on logger (>= 0) is not recommended
  use a bounded requirement, such as "~> x.y"
WARNING:  open-ended dependency on rack (>= 2.2.23, development) is not recommended
  if rack is semantically versioned, use:
    add_development_dependency "rack", "~> 2.2", ">= 2.2.23"
WARNING:  See https://guides.rubygems.org/specification-reference/ for help

@Jens-G Jens-G requested a review from kpumuk as a code owner April 28, 2026 20:20
@mergeable mergeable Bot added the ruby Pull requests that update Ruby code label Apr 28, 2026
@kpumuk
Copy link
Copy Markdown
Member

kpumuk commented Apr 28, 2026

I would honestly ignore the warnings, they are aimed at applications and not libraries. With this change people will not be able to use Thrift gem with modern popular libraries, like Sidekiq.

@Jens-G Jens-G closed this Apr 28, 2026
@Jens-G Jens-G deleted the rb-gemspec branch May 7, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants