[GO] Fix range check on 32-bit architectures#3428
Merged
Merged
Conversation
kpumuk
approved these changes
Apr 29, 2026
fishy
approved these changes
Apr 29, 2026
hc-github-team-secure-vault-core
added a commit
to hashicorp/vault
that referenced
this pull request
May 7, 2026
…#14581) (#14628) * go: resolve GHSA-wf45-q9ch-q8gh by upgrading github.com/apache/thrift `github.com/apache/thrift` is required for the snowflake plugin. I've updated that upstream[0] so this change is only necessary to get past the scanner until a new version of the snowflake plugin is released and we've updated our pin. Using v0.23.0 was actually not possible since there's an overflow on 32 bit architectures. Instead, we use the first commit since the release that fixes that issue.[1] [0]:hashicorp/vault-plugin-database-snowflake#181 [1]:apache/thrift#3428 Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
hc-github-team-secure-vault-core
added a commit
to hashicorp/vault
that referenced
this pull request
May 7, 2026
…#14581) (#14631) (#14647) * go: resolve GHSA-wf45-q9ch-q8gh by upgrading github.com/apache/thrift `github.com/apache/thrift` is required for the snowflake plugin. I've updated that upstream[0] so this change is only necessary to get past the scanner until a new version of the snowflake plugin is released and we've updated our pin. Using v0.23.0 was actually not possible since there's an overflow on 32 bit architectures. Instead, we use the first commit since the release that fixes that issue.[1] [0]:hashicorp/vault-plugin-database-snowflake#181 [1]:apache/thrift#3428 Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
|
Hi, would it be possible to tag a new release with this fix? We're unable to upgrade since we need to support 32-bit architectures |
Member
You can use |
|
Thank you, we will do that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #3381 introduced range checks for integer values, however, one of the checks fails with
on 32-bit architectures. This is because
math.MaxUint32is ofuntyped intwhich is a signed 32-bit integer on those architectures and thus cannot hold the maximum 32-bit unsigned value.This PR fixes the issue by comparing the values as
uint64values avoiding potential overflows.[skip ci]anywhere in the commit message to free up build resources.