THRIFT-5785: fix boost include#3431
Merged
Merged
Conversation
- It is only used in THeaderTransport.cpp so move it there without compicating it - It throws a TTransportException so it should not be used in other code - People that depends on this can use boost::numeric_cast or std::in_range instead - The usage in the unit test was not needed since std::string::size() returns an unsigned long on 64 compilers
5 tasks
Contributor
Author
|
PS: just rewriting the offending function without using boost was more complex than I have anticipated (see the linked tickets) |
emmenlau
approved these changes
Apr 30, 2026
Member
emmenlau
left a comment
There was a problem hiding this comment.
Looks good to me. I did not check test results. If tests are green, please merge!
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove another boost header include from the public API
boost::numeric_castorstd::in_range(C++20) insteadstd::string::size()returns anunsigned longon 64-bit compilers[skip ci]anywhere in the commit message to free up build resources.The following tickets are releated