THRIFT-2925 CMake build does not work with OpenSSL nor anything installe... #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lled in non-system location This diff fixes them by correcting invalid CMake variable names: * OPENSSL_... rather than OpenSSL_... * LIBEVENT_... rather than Libevent_... * Boost_INCLUDE_DIRS rather than Boost_INCLUDE_DIR * LIBEVENT_INCLUDE_DIRS rather than LIBEVENT_INCLUDE_DIR * ZLIB_INCLUDE_DIRS rather than ZLIB_INCLUDE_DIR Note: * OPENSSL_INCLUDE_DIR is correct (rather than ..._DIRS) * Boost_INCLUDE_DIR exists and actually works for most cases but Boost_INCLUDE_DIRS is the one desinged to be included Also, library headers are now included as SYSTEM headers.
Member
Author
|
Merged as c444fb5, thanks :) |
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
proposing to change back SE.REdis synctimeout to be 1 second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...d in non-system location
This diff fixes them by correcting invalid CMake variable names:
Note:
Boost_INCLUDE_DIRS is the one desinged to be included
Also, library headers are now included as SYSTEM headers.