Skip to content

Fixing bundler on ruby-head build#3454

Merged
kpumuk merged 1 commit intoapache:masterfrom
kpumuk:ruby41-bundler
May 9, 2026
Merged

Fixing bundler on ruby-head build#3454
kpumuk merged 1 commit intoapache:masterfrom
kpumuk:ruby41-bundler

Conversation

@kpumuk
Copy link
Copy Markdown
Member

@kpumuk kpumuk commented May 9, 2026

One of the constants in Pathname was marked as private. The constants is used in all Bundler versions, and only landed on master and is not released as of today (4.0.11 is the current version). This makes ruby-head incompatible with any Bundler released to date.

This change switched ruby-head to use bundled Bundler instead of the version locked in our Gemfile.lock.

I personally don't like this and my best guess is that the change will be reverted (or made backwards-compatible), as the scale is large, but for now this MR fixed Thrift builds.

There is an active discussion going on to deprecate instead of breaking things, will monitor.

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@kpumuk kpumuk requested review from Jens-G, fishy and jimexist as code owners May 9, 2026 17:09
@mergeable mergeable Bot added the github_actions Pull requests that update GitHub Actions code label May 9, 2026
@kpumuk kpumuk force-pushed the ruby41-bundler branch from 0d77181 to ff16583 Compare May 9, 2026 17:13
@kpumuk kpumuk force-pushed the ruby41-bundler branch from ff16583 to 071f46c Compare May 9, 2026 17:21
@kpumuk kpumuk merged commit 0695e7e into apache:master May 9, 2026
94 of 96 checks passed
@kpumuk kpumuk deleted the ruby41-bundler branch May 9, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant