THRIFT-6002: Add netstd codegen test script and GitHub Actions CI matrix job#3481
Merged
Conversation
mergeable
Bot
added
c#
…rix job Client: netstd Tests the netstd code generator by compiling every .thrift file in the repository against the Thrift library for .NET 8, 9, and 10 via a matrix CI job. The PowerShell script supports optional parameters for target versions, output folder, and extra IDL search path, keeping local dev behaviour unchanged when called without arguments. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/netstd/Tests/codegen/run-NetStd-Codegen-Tests.ps1: a PowerShell script that tests the netstd code generator by compiling every.thriftfile in the repository against the Thrift library for each target .NET version-TargetVersions,-TargetFolder,-ExtraThriftFiles(backward-compatible; default behaviour unchanged when called without arguments)lib-netstd-codegenjob to.github/workflows/build.ymlas a matrix over .NET 8, 9, 10 — uses the pre-builtthrift-compilerartifact andactions/setup-dotnetHow the test works
For each
.thriftfile:thrift --gen netstd:<version>to produce C# code.slnx) and.csprojreferencinglib/netstd/Thrift/Thrift.csprojdotnet build— any compile error is a codegen regressionKnown-failure lists in the script handle files that are intentionally expected to fail.
Test plan
lib-netstd-codegen (8),lib-netstd-codegen (9),lib-netstd-codegen (10)in Actions UIbuild.ymlare affectedNotes
actions/setup-dotnetpinned to SHA67a3573c9a986a3f9c594539f4ab511d57bb3ce9(v4.3.1)🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com