Skip to content

THRIFT-6006: Implement MESSAGE_SIZE_LIMIT exception type for Haxe library #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jens-G merged 1 commit into from
May 15, 2026
+5 −3
Merged

THRIFT-6006: Implement MESSAGE_SIZE_LIMIT exception type for Haxe library #3485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/haxe/src/org/apache/thrift/transport/TEndpointTransport.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class TEndpointTransport extends TTransport

// update only: message size can shrink, but not grow
if (newSize > KnownMessageSize)
throw new TTransportException(TTransportException.END_OF_FILE, "ResetConsumedMessageSize: MaxMessageSize reached");
throw new TTransportException(TTransportException.MESSAGE_SIZE_LIMIT, 'ResetConsumedMessageSize: message size exceeds limit ${MaxMessageSize}');

KnownMessageSize = newSize;
RemainingMessageSize = newSize;
Expand All @@ -79,7 +79,7 @@ class TEndpointTransport extends TTransport
public override function CheckReadBytesAvailable(numBytes : Int64) : Void
{
if (RemainingMessageSize < numBytes || numBytes < 0)
throw new TTransportException(TTransportException.END_OF_FILE, 'CheckReadBytesAvailable(${numBytes}): MaxMessageSize reached, only ${RemainingMessageSize} bytes available');
throw new TTransportException(TTransportException.MESSAGE_SIZE_LIMIT, 'CheckReadBytesAvailable(${numBytes}): message size exceeds limit ${MaxMessageSize}, only ${RemainingMessageSize} bytes available');
}

// Consumes numBytes from the RemainingMessageSize.
Expand All @@ -92,7 +92,7 @@ class TEndpointTransport extends TTransport
else
{
RemainingMessageSize = 0;
throw new TTransportException(TTransportException.END_OF_FILE, 'CountConsumedMessageBytes(${numBytes}): MaxMessageSize reached');
throw new TTransportException(TTransportException.MESSAGE_SIZE_LIMIT, 'CountConsumedMessageBytes(${numBytes}): message size exceeds limit ${MaxMessageSize}');
}
}
}
2 changes: 2 additions & 0 deletions lib/haxe/src/org/apache/thrift/transport/TTransportException.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ class TTransportException extends TException {
public static inline var ALREADY_OPEN : Int = 2;
public static inline var TIMED_OUT : Int = 3;
public static inline var END_OF_FILE : Int = 4;
public static inline var CORRUPTED_DATA : Int = 5;
public static inline var MESSAGE_SIZE_LIMIT : Int = 6;

public function new(error : Int = UNKNOWN, message : String = "") {
super(message, error);
Expand Down
Loading