THRIFT-6014: Add recursion depth limit to skip() in JavaScript library#3500
Merged
Conversation
Client: js Aligns the browser JavaScript library skip() with the Node.js protocols (binary, compact, JSON), which already enforce a depth limit of 64. Adds a depth parameter and throws TProtocolException with DEPTH_LIMIT when depth exceeds 64. Adds a QUnit test harness covering the boundary. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depthparameter toThrift.Protocol.prototype.skipinlib/js/src/thrift.jsTProtocolExceptionwithDEPTH_LIMITwhen depth exceeds 64lib/nodejs/) which already enforce this limittest-skip-depth.js) and corresponding HTML harness covering the limit boundaryTest plan
lib/js/test/test-skip-depth.html— new tests: throwsDEPTH_LIMITwhen called at depth 64 (increments to 65), no throw at depth 63 for a leaf type🤖 Generated with Claude Code