THRIFT-6016: Move jsdoc from dependencies to devDependencies in lib/ts#3505
Merged
Conversation
Client: ts jsdoc is a documentation generator and must not be a runtime dependency. Having it under dependencies caused taffydb and lodash to be classified as production transitive dependencies, inflating the vulnerability surface of the published npm package. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsdocis a documentation generator and must not be a runtime dependency of the Thrift TypeScript library.dependenciescausedtaffydb(abandoned, HIGH) andlodashto be classified as production transitive dependencies, inflating the vulnerability surface of the published npm package.jsdoctodevDependenciesand regeneratedpackage-lock.json;taffydbandlodashare now correctly classified as dev-only.Test plan
npm install --omit=devinlib/tsno longer installs jsdoc, taffydb, or lodash.npm install(with devDependencies) still succeeds and doc generation viagrunt jsdocstill works.Related
🤖 Generated with Claude Code