THRIFT-6020: Fix npm audit vulnerabilities in lib/ts and lib/nodejs#3512
Merged
Conversation
Client: ts,js lib/ts: bump grunt to ^1.6.2; add overrides for bn.js, brace-expansion, grunt-legacy-log, grunt-legacy-log-utils, grunt-legacy-util, micromatch, semver, trim-newlines. Reduces vulnerabilities from 18 to 8 (jshint->lodash and elliptic chains have no available fix). lib/nodejs (root): bump eslint to ^9.27.0; add overrides for @babel/helpers, ajv, brace-expansion, debug, semver, underscore. Reduces vulnerabilities to 0. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gruntto^1.6.2; addoverridesforbn.js,brace-expansion,grunt-legacy-log,grunt-legacy-log-utils,grunt-legacy-util,micromatch,semver,trim-newlines. Reduces audit findings from 18 → 8.package.json): bumpeslintto^9.27.0; addoverridesfor@babel/helpers,ajv,brace-expansion,debug,semver,underscore. Reduces audit findings to 0.This is the sweep ticket for the THRIFT-6016 series (follows THRIFT-6017, THRIFT-6018, THRIFT-6019).
Remaining unfixable in lib/ts (8)
grunt-contrib-jshint→jshint→lodash,minimatchlodash ≤4.17.23andminimatch ≤3.1.3have no published fix; alljshint@2.xreleases are affectedelliptic→browserify-sign,create-ecdh,crypto-browserifyellipticversions are flagged; devDependency onlyAll remaining findings are in devDependencies only and do not affect the published package.
Test plan
npm auditinlib/ts/reports 8 vulnerabilities (4 high jshint chain, 4 low elliptic chain)npm auditin repo root reports 0 vulnerabilitiesnpx gruntinlib/ts/continues to work (qunit tests use puppeteer)🤖 Generated with Claude Code