Please add more OSGI package exports to the Java manifest file#36
Closed
mattmarshall wants to merge 1 commit intoapache:masterfrom
mattmarshall:master
Closed
Please add more OSGI package exports to the Java manifest file#36mattmarshall wants to merge 1 commit intoapache:masterfrom mattmarshall:master
mattmarshall wants to merge 1 commit intoapache:masterfrom
mattmarshall:master
Conversation
Contributor
|
Thank you for issuing a pull request for your patch. Currently we do not accept pull requests from Github, please see http://thrift.apache.org/docs/HowToContribute/ for instructions on submitting your patch back to Apache Thrift. Thanks |
Author
|
Ok thank you, I've signed up for a JIRA account and see that the issue is being tracked in THRIFT-184. |
jsgf
pushed a commit
to jsgf/thrift
that referenced
this pull request
Jul 16, 2016
jsgf
pushed a commit
to jsgf/thrift
that referenced
this pull request
Jul 16, 2016
jsgf
pushed a commit
to jsgf/thrift
that referenced
this pull request
Jul 31, 2016
jsgf
pushed a commit
to jsgf/thrift
that referenced
this pull request
Jul 31, 2016
keynslug
pushed a commit
to keynslug/thrift
that referenced
this pull request
Feb 27, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to use the Thrift jar in an OSGI application, I get the following error:
Upon further inspection, I noticed that the jar's manifest file only exports the package org.apache.thrift, which is useful but arguably not sufficient in scope for most applications (I need access to TSimpleServer, etc.)
Please consider adding additional package exports so I don't have to re-wrap the compiled class files in a custom manifest. Thanks :)