Node.js: Fixed retry delay #393
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call `initialize_retry_vars()` in `Connection`'s constructor, so that `retry_delay` does not become `NaN` after multiplying two `null` values. This resulted in the retry delay always being instant, since calling `setTimeout()` with `NaN` is equivalent to calling it with 0 ms. - Fixed `retry_max_delay` logic: The max value should be applied after calculating the next `retry_delay`. Previously, the connection would allow one delay to be greater than the max. And after that every second delay would be greater than the max, since the code was using `>` to compare the last retry delay (which was the max) and the max, which would always be false.
Contributor
|
Thanks for the patch @sebastianseilund, closing as #393 has a more complete patch for this and additional issues |
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize_retry_vars()inConnection's constructor, so thatretry_delaydoes not becomeNaNafter multiplying twonullvalues. This resulted in the retry delay always being instant, since callingsetTimeout()withNaNis equivalent to calling it with 0 ms.retry_max_delaylogic: The max value should be applied after calculating the nextretry_delay. Previously, the connection would allow one delay to be greater than the max. And after that every second delay would be greater than the max, since the code was using>to compare the last retry delay (which was the max) and the max, which would always be false.