THRIFT-3130 finish removal of THRIFT_OVERLOAD_IF #483
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeking3
force-pushed
the
bugfix/remove-thrift-overload-if-unnecessary
branch
from
6dadd7b to
3388ef4
Compare
jeking3
force-pushed
the
bugfix/remove-thrift-overload-if-unnecessary
branch
from
3388ef4 to
929a745
Compare
Contributor
Author
|
I made some small changes to the TServerIntegrationTest to support testing THRIFT-1944 and rebased the fixup so there's still only one commit tag. The resulting build failed early so I recycled the pull request. The previous two builds of this fix passed. |
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
May 8, 2015
Client: C++ Patch: Jim King <jim.king@simplivity.com> This closes apache#483
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: C++ Patch: Jim King <jim.king@simplivity.com> This closes apache#483
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing proved it was unnecessary.