Skip to content

THRIFT 3089 - stop adding period before enum name unless java namespace is provided#490

Closed
mreve wants to merge 1 commit intoapache:masterfrom
mreve:THRIFT-3089
Closed

THRIFT 3089 - stop adding period before enum name unless java namespace is provided#490
mreve wants to merge 1 commit intoapache:masterfrom
mreve:THRIFT-3089

Conversation

@mreve
Copy link
Copy Markdown

@mreve mreve commented May 12, 2015

Using the example from issue's description:

IDL file contains:

struct Params {
    1: optional Color bColor = Color.BLACK; 
}

Compiled to java (no namespace):

public Params() {
    this.bColor = .Color.BLACK;
}

How it looks like with namespace enumtest:

public Params() {
    this.bColor = enumtest.Color.BLACK;
}

This fix prevents adding the period sign when there's no java namespacec provided in the IDL file.

Compare:
https://issues.apache.org/jira/browse/THRIFT-3089

@mreve mreve changed the title Stopped adding period before enum name unless namespace is provided THRIFT 3089 - stop adding period before enum name unless java namespace is provided May 12, 2015
@asfgit asfgit closed this in eab9c45 May 12, 2015
allengeorge pushed a commit to allengeorge/thrift that referenced this pull request Jan 1, 2017
…ava code if java namespace is not defined

Client: Java
Patch: Anna Dymek <aadymek@gmail.com>

This closes apache#490
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant