THRIFT-3150 go: add option to generate non-exported Read and Write me… #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thods This change adds a new option to Go trift compiler: dont_export_rw. When it is specified generated Read and Write methods will be called 'read' and 'write' (and hence are non-exported). This can be useful if a package author wants to make the generated structs part of public package API but doesn't want the package depend on thrift library. This will make vendoring thrift library easier too.
allengeorge
pushed a commit
to allengeorge/thrift
that referenced
this pull request
Jan 1, 2017
Client: Go Patch: Konstantin Shaposhnikov <k.shaposhnikov@gmail.com>, slightly modified by Jens Geyer This closes apache#505
Jens-G
pushed a commit
to Jens-G/thrift
that referenced
this pull request
Apr 14, 2019
Add ThreadPool and CPU summary to connection related errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…thods
This change adds a new option to Go trift compiler: dont_export_rw.
When it is specified generated Read and Write methods will be called 'read' and
'write' (and hence are non-exported).
This can be useful if a package author wants to make the generated structs part
of public package API but doesn't want the package depend on thrift
library. This will make vendoring thrift library easier too.