Thrift 3265--servers for pipe applications (stdin, stdout) #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 18, 2015 17:03
…stIOStreamClient class which tests the TStreamServer by having the client spawn the server and use stream transport
…lso have binary protocol as the default
…iftTest will compile
…nal makefile and script
added 21 commits
July 20, 2015 15:13
…OStreamServer from subdirectories in makefile
… (clean target was happening after generate)
…p comments in other files
Member
|
Hi, great Addition, but please clean it up before I take a look at it. For starters, all those "generated files" are not to be included. |
Member
There was a problem hiding this comment.
Whats that copyright notice? Are you sure your are legally allowed to put that code into Open Source at all? How can we check that?
Author
There was a problem hiding this comment.
That is a good catch... I am not sure that we can contribute it, and I am working to find out. I will probably take it off github for the time being because I should have thought of this sooner!
jeking3
added a commit
to jeking3/thrift
that referenced
this pull request
Nov 30, 2017
This closes apache#387 This closes apache#480 This closes apache#562 This closes apache#657 This closes apache#701 This closes apache#784 This closes apache#794 This closes apache#896 This closes apache#947 This closes apache#1012 This closes apache#1015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds server classes to C#, Python, and Java libraries for server/client communication over stdin and stdout.